-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler: improve the failed event of Reservation's scheduling #1947
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1947 +/- ##
=======================================
Coverage 67.50% 67.51%
=======================================
Files 420 420
Lines 46961 47040 +79
=======================================
+ Hits 31703 31760 +57
- Misses 12949 12968 +19
- Partials 2309 2312 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: buptcozy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…dinator-sh#1947) Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com> Co-authored-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
Ⅰ. Describe what this PR does
The reservation plugin of koord-scheduler traverses all reservations with the Restricted policy and determines whether a certain Reservation satisfies the Pod. When all reservations cannot be satisfied, we lose reasonable information, such as which resources cannot be satisfied, which can help users diagnose themselves.
So this PR aggregate these messages to users.
Ⅱ. Does this pull request fix one issue?
fixes #1909
Ⅲ. Describe how to verify it
make pods requiring allocate resource from reservation, check the failed event, like follows.
Warning FailedScheduling 12s default-scheduler 0/50 nodes are available: 1 Insufficient cpu by reservation.
Ⅳ. Special notes for reviews
V. Checklist
make test